Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A very strange roomba. #523
base: master
Are you sure you want to change the base?
A very strange roomba. #523
Changes from all commits
bde259d
27c3343
9d970a6
0ced948
f47ec40
7231b0f
71d2810
4f34ee6
669f283
b49ddae
ccecfc2
46f6eed
4c2be44
0ce1bbf
3ed2403
11ca87a
3eca413
bef388a
363ea46
4d7a899
6da5ee5
96c5299
fdd2f52
a51c4e3
12fe6b4
66decbc
3df4dfb
ad727b1
789446b
8f0ebbd
7a637cc
186ab7e
279a434
ea25d23
ed6a49b
aed8f00
1303364
b67c9be
6f7fe15
d2bde2d
34ec30e
924b2ca
9d5cd62
7c4a633
d3f4cca
bda8a8a
78e8892
7854fd2
56a57bf
225dcf6
a3b0da4
12171d6
31362ea
8f88268
a5345e2
daa3869
a27d4bd
dfc95c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, if it fails to TK then it forces an
attack_hand
?That seems very prone to causing bugs (off the top of my head you can click on any target out of range to interact with it, because out of range -> focus fails, which in turn means you can teleport stuff from across the room)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so it can open doors and such if it cannot lift the object. Is there something else i can call for it to be able to do that?EDIT: I got confused, this is the thing that actually makes the telekinesis work in the first place. If I do not have it, it cannot lift up objects telekinetically. The
on_unarmed_attack
proc is the one for doors, not this one.Something similar is in the actual telekinesis code as well, so that is why it is here. I forgot the exaaact reason for it though.
As of right now, it cannot pick up items that is out of range due to a bunch of checks.
Unless you mean the
COMPONENT_CANCEL_ATTACK_CHAIN
part? I thought that cancels the attack chain. Did I misunderstand how that works?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused what's going on here exactly, I think this code is to make
unarmed_attack
callattack_hand
?Have you tried looking into
resolve_unarmed_attack
? It might cover this for youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called so it can interact with doors and lockers and whatnot at range.
Its because the mobs that can get the tractor field component doesn't actually have a
on_unarmed_attack
. I tried to useresolve_unarmed_attack
but that just made the Vroomba attack itself when I clicked on a door. doors do not have aresolve_unarmed_attack
so I cannot call it on that either...Maybe I am just confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this
update_held_items
for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no idea, I copied this from the dextrous component...