Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts station trait costs, adds general budget #460

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

MrMelbert
Copy link
Owner

Strait trait costs: Good in theory, but fails in practice.

While in theory this allows for more rare traits to shine by leaving behind some "budget" to purchase more impactful traits along side smaller ones, in practice this means the less impactful traits (already regulated by higher weights) become soft-guaranteed to roll: as they effectively combine their weights into one.

When you have a budget of 1, and you roll a trait that costs 0.3, you are left with 0.7. Now you can't buy any traits that cost 1, but we still want to spend the rest of the budget, so we are now guaranteed to buy a bunch of things that cost 0.5 or 0.3. This sucks in practice.

So I reverted it. All traits are 1 cost.

But I didn't revert it to how the system used to be. In the past, it would roll 3 numbers for num positive, num neutral and num negative.
Instead, we just roll 1 big pool and then randomly pick from either positive, neutral, or negative, as we attempt to fill out or budget.

Why am I doing this? I think it will result in more "dynamic" rounds than when it used to be. While in the past most rounds felt rather standard: You get something positive, something negative, and something neutral. Instead now, in some rounds you will feel blessed, and be given many positives, and in some rounds you will feel cursed, and be given many negatives. Or you will get the standard balanced result. Or who knows!

Also remember this is config so it can be easily easily tweaked

@MrMelbert MrMelbert added the Adjustment Tweaking something to be better, maybe label Mar 18, 2024
@MrMelbert MrMelbert changed the title Reverts trait costs, adds general budget Reverts station trait costs, adds general budget Mar 18, 2024
NEGATIVE_STATION_TRAITS 1 4
NEGATIVE_STATION_TRAITS 2 2
NEGATIVE_STATION_TRAITS 3 1
## Adds up to 100 for easy math: The weight = the % chance of being picked.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be rewritten to not make it seem like the combined total has to be 100.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is to encourage the end user to keep the combined total at 100

@MrMelbert MrMelbert merged commit 756f535 into master Mar 24, 2024
22 checks passed
@MrMelbert MrMelbert deleted the trait_revert branch March 24, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjustment Tweaking something to be better, maybe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants