[MDB Ignore] [IDB Ignore] [MDB IGNORE] [IDB IGNORE] Upstream Merge, filter created digitigrade clothing sprites, some other stuff

.dockerignore

@@ -22,6 +22,11 @@ tgstation.int
 tgstation.rsc
 tgstation.lk
 tgstation.dyn.rsc
+maplestation.dmb
+maplestation.int
+maplestation.rsc
+maplestation.lk
+maplestation.dyn.rsc
 *.dll
 Dockerfile
 tools/bootstrap/.cache

.github/CODEOWNERS

@@ -7,11 +7,7 @@
 #CRITAWAKETS
 # /_maps/map_files/PubbyStation/PubbyStation.dm @CRITAWAKETS
 
-#doshMobile
-/maplestation_modules/icons/ @doshMobile
-
 #mrmelbert
-/maplestation_modules/
-
-#sqnztb
-/_maps/map_files/LimaStation/LimaStation.dm @sqnztb
+/code/
+/_maps/
+/icons/

.github/CONTRIBUTING.md

@@ -90,6 +90,8 @@ Things you **CAN'T** do:
 * [Close PRs](https://imgur.com/w2RqpX8.png): Only maintainers are allowed to close PRs. Do not hit that button.
 * Close issues purely for breaking a template if the same information is contained without it.
 
+For more information reference the [Issue Manager Guide](.github/guides/ISSUE_MANAGER.md).
+
 </details>
 
 ## Development Guides
@@ -105,7 +107,7 @@ Things you **CAN'T** do:
 
 #### Misc
 
-- [AI Datums](../code/datums/ai/making_your_ai.md)
+- [AI Datums](../code/datums/ai/learn_ai.md)
 - [Embedding TGUI Components in Chat](../tgui/docs/chat-embedded-components.md)
 - [Hard Deletes](./guides/HARDDELETES.md)
 - [MC Tab Guide](./guides/MC_tab.md)

.github/alternate_byond_versions.txt

@@ -5,5 +5,3 @@
 # Format is version: map
 # Example:
 # 500.1337: runtimestation
-
-515.1603: runtimestation

.github/gbp.toml

@@ -9,6 +9,7 @@ reset_label = "GBP: Reset"
 "Code Improvement" = 2
 "Documentation" = 1
 "Feature" = -6
+"Good First PR" = 6
 "Feedback" = 2
 "Fix" = 3
 "Grammar and Formatting" = 1

.github/guides/ISSUE_MANAGER.md

@@ -0,0 +1,91 @@
+## What is an Issue Manager
+
+Issue Managers proactively manage issues for the repo by providing feedback, performing triage, and troubleshooting problems.  They search through the codebase to link relevant code, issues, and PRs that help contributors identify and solve an issue.
+
+## Triage An Issue
+
+New issues should be properly diagnosed by using several methods and tools below:
+
+#### Emergency Issues
+
+When examining new issues you should immediately notify a maintainer if you see the following:
+
+- **Security Exploit** [[1]](https://github.com/tgstation/tgstation/issues/51654) [[2]](https://github.com/tgstation/tgstation/issues/38407) [[3]](https://github.com/tgstation/tgstation/issues/9900) - Something that can be used to bypass bans, give a player admin powers, cheats or hacks
+- **Server Crashing** [[1]](https://github.com/tgstation/tgstation/issues/29342) [[2]](https://github.com/tgstation/tgstation/issues/25890) [[3]](https://github.com/tgstation/tgstation/issues/17475) - Something that is causing the server to _consistently_ crash
+- **Server Lagging** [[1]](https://github.com/tgstation/tgstation/issues/60193) [[2]](https://github.com/tgstation/tgstation/issues/51927) [[3]](https://github.com/tgstation/tgstation/issues/32762) - Something that is causing a _severe_ amount of lag during the game
+
+#### Runtime Issue Reports
+If an issue reports a runtime, it must have the actual runtime call stack provided by round logging or in-game debug menu (https://github.com/tgstation/tgstation/issues/70329#issuecomment-1279853883). 
+<details>
+  <summary>Example runtime call stack</summary>
+
+  ```
+  [2022-10-15 16:12:38.902] runtime error: Cannot execute null.add().
+ - proc name: visibility (/datum/cameranet/proc/visibility)
+ -   source file: cameranet.dm,88
+ -   usr: AI (/mob/living/silicon/ai)
+ -   src: Camera Net (/datum/cameranet)
+ -   usr.loc: the floor (150,25,4) (/turf/open/floor/circuit)
+ -   call stack:
+ - Camera Net (/datum/cameranet): visibility(/list (/list), null, /list (/list), 1)
+ - AI (/mob/living/silicon/ai): camera visibility(Inactive AI Eye (/mob/camera/ai_eye))
+ - Inactive AI Eye (/mob/camera/ai_eye): setLoc(the floor (150,25,4) (/turf/open/floor/circuit), 0)
+ - AI (/mob/living/silicon/ai): create eye()
+ - AI (/mob/living/silicon/ai): Initialize(0, null, TagGamerGame2 (/mob/dead/new_player))
+ - Atoms (/datum/controller/subsystem/atoms): InitAtom(AI (/mob/living/silicon/ai), 0, /list (/list))
+ - AI (/mob/living/silicon/ai): New(0, null, TagGamerGame2 (/mob/dead/new_player))
+ - AI (/mob/living/silicon/ai): New(the floor (150,25,4) (/turf/open/floor/circuit), null, TagGamerGame2 (/mob/dead/new_player))
+ - /datum/job/ai (/datum/job/ai): get spawn mob(TagGamerGame2 (/client), AI (/obj/effect/landmark/start/ai))
+ - TagGamerGame2 (/mob/dead/new_player): create character(AI (/obj/effect/landmark/start/ai))
+ - Ticker (/datum/controller/subsystem/ticker): create characters()
+ - Ticker (/datum/controller/subsystem/ticker): setup()
+ - Ticker (/datum/controller/subsystem/ticker): fire(0)
+ - Ticker (/datum/controller/subsystem/ticker): ignite(0)
+  ```
+
+</details>
+
+#### Downstream Issues Taken Upstream
+If an issue reports a bug encountered at a branch of the codebase or on a downstream server, it __MUST__ have a link to the branch or downstream codebase repo or it is eligible for closing (https://github.com/tgstation/tgstation/issues/70875#issuecomment-1295767891). Reproducing the issue on the compiled master of our codebase is also encouraged.
+
+<details>
+  <summary>Image macro for your issue marking pleasure</summary>
+
+![image](https://user-images.githubusercontent.com/39163353/198381160-f0aa7fc4-4f2d-486f-8b33-44a1965e2ad1.svg)
+
+`![image](https://user-images.githubusercontent.com/39163353/198381160-f0aa7fc4-4f2d-486f-8b33-44a1965e2ad1.svg)`
+</details>
+
+#### Link Code Snippets
+
+To help triangulate bugs, search the GitHub repo to locate relevant code and attach it to an issue.  Do this by creating a [link to the code](https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/creating-a-permanent-link-to-a-code-snippet).  This saves the contributors time from having to identify the problem and will be appreciated.
+
+#### Use Gitblame
+
+GitHub also has a tool called `gitblame` that is useful in [tracking code](https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#viewing-the-line-by-line-revision-history-for-a-file) to determine who and when someone made a change.  This is ideally used to help solve old issues when there is uncertainty over which PR might have fixed it.  It is also a good tool to use to link PRs that caused the issue.
+
+#### Search For Keywords
+
+When a new issue appears search for any keywords involved with the issue.  This is important to prune for duplicates, match several issues to a test merge PR, or if you want to link multiple issues together since there is overlapping problems. (but not duplicate)
+
+## Closing Issues
+
+It is recommended to close issues in the following situations:
+
+- **Feature Requests** [[1]](https://github.com/tgstation/tgstation/issues/55919) [[2]](https://github.com/tgstation/tgstation/issues/53342) [[3]](https://github.com/tgstation/tgstation/issues/45412) - The issue is a suggestion or request for a new feature to be added to the game.
+- **Working as Intended** [[1]](https://github.com/tgstation/tgstation/issues/62619) [[2]](https://github.com/tgstation/tgstation/issues/61511) [[3]](https://github.com/tgstation/tgstation/issues/60942) - The issue is detailing a problem that is _specifically intended_ by the code and is not considered a bug.
+- **Duplicates** [[1]](https://github.com/tgstation/tgstation/issues/62709) [[2]](https://github.com/tgstation/tgstation/issues/62364) [[3]](https://github.com/tgstation/tgstation/issues/61823) - The issue is detailing an identical problem from another issue. Do not automatically close the most recent issue.  Instead compare both and close the one that provides the least information.
+- **Removed Features** [[1]](https://github.com/tgstation/tgstation/issues/48255) [[2]](https://github.com/tgstation/tgstation/issues/47194) [[3]](https://github.com/tgstation/tgstation/issues/45653) - The issue is referring to something that was removed from the codebase and no longer exists.
+- **Defective Issues** [[1]](https://github.com/tgstation/tgstation/issues/57366) [[2]](https://github.com/tgstation/tgstation/issues/48778) [[3]](https://github.com/tgstation/tgstation/issues/51520) - The issue is badly written and lacking information.  Politely ask the person to add more information or rewrite the issue.  If there is no response after a sufficient amount of time close the issue.
+- **Irreproducible Issues** [[1]](https://github.com/tgstation/tgstation/issues/51493) [[2]](https://github.com/tgstation/tgstation/issues/22796) [[3]](https://github.com/tgstation/tgstation/issues/25610) - The issue is old, cannot be reproduced, and nobody has reported a duplicate issue recently.  If you feel _confident_ that the issue has been fixed at some point, list your reasons or link possible PRs that could have fixed it.
+- **Impossible to Fix Issues** [[1]](https://github.com/tgstation/tgstation/issues/524) [[2]](https://github.com/tgstation/tgstation/issues/2679) [[3]](https://github.com/tgstation/tgstation/issues/9637) - The issue is not possible to fix due to either vague details or a clearly defined problem.
+
+## Reopening Issues
+
+In special cases a closed issue should be reopened if:
+
+- It has been updated with pertinent information (when before it was lacking info making it defective)
+- The initial problem has reappeared (after it was presumably fixed in a PR)
+- Someone feels that the issue was closed prematurely during discussion
+
+If there is a dispute on whether an issue should remain closed, ask for a second opinion.  Get clarification from another Issue Manager or Maintainer and respect their judgement as the final verdict.

.github/guides/MAPS_AND_AWAY_MISSIONS.md

@@ -1,17 +1,18 @@
 ## MAPS
 
-/tg/station currently has five station maps in rotation.
+/tg/station currently has six station maps in rotation.
+* [Birdshot](https://tgstation13.org/wiki/Birdshot)
 * [DeltaStation](https://tgstation13.org/wiki/DeltaStation)
 * [IceBoxStation](https://tgstation13.org/wiki/IceboxStation)
-* [KiloStation](https://tgstation13.org/wiki/KiloStation)
 * [MetaStation](https://tgstation13.org/wiki/MetaStation)
+* [NorthStar](https://tgstation13.org/wiki/The_North_Star)
 * [TramStation](https://tgstation13.org/wiki/Tramstation)
 
 Debug station maps.
 * [RuntimeStation](https://tgstation13.org/wiki/RuntimeStation)
 * [MultiZ](https://tgstation13.org/wiki/MultiZ)
 
-All maps have their own code file that is in the base of the `_maps` directory, or elsewhere in the codebase. For example, all of the station maps in rotation each have a corresponding JSON file and are loaded using `maps/_basemap.dm`. Maps are loaded dynamically when the game starts. Follow this guideline when adding your own map, to your fork, for easy compatibility.
+All maps have their own code file that is in the base of the `_maps` directory, or elsewhere in the codebase. For example, all of the station maps in rotation each have a corresponding JSON file and are loaded using the server's [configuration](#configuration) passed onto the Mapping subsystem. Maps are loaded dynamically when the game starts. Follow this guideline when adding your own map, to your fork, for easy compatibility.
 
 The map that will be loaded for the upcoming round is determined by reading `data/next_map.json`, which is a copy of the JSON files found in the `_maps` tree. If this file does not exist, the default map from `config/maps.txt` will be loaded. Failing that, MetaStation will be loaded. If you want to set a specific map to load next round you can use the Change Map verb in game before restarting the server or copy a JSON from `_maps` to `data/next_map.json` before starting the server. Also, for debugging purposes, ticking a corresponding map's code file in Dream Maker will force that map to load every round.
 

.github/guides/STYLE.md

@@ -303,6 +303,47 @@ world.log << "[apples] apples left, taking one."
 apples--
 ```
 
+### initial() versus ::
+`::` is a compile time scope operator which we use as an alternative to `initial()`.
+It's used within the definition of a datum as opposed to `Initialize` or other procs.
+
+```dm
+// Bad
+/atom/thing/better
+	name = "Thing"
+
+/atom/thing/better/Initialize()
+	var/atom/thing/parent = /atom/thing
+	desc = inital(parent)
+
+// Good
+/atom/thing/better
+	name = "Thing"
+	desc = /atom/thing::desc
+```
+
+Another good use for it easy access of the parent's variables.
+```dm
+/obj/item/fork/dangerous
+	damage = parent_type::damage * 2
+```
+
+```dm
+/obj/item/fork
+	flags_1 = parent_type::flags_1 | FLAG_COOLER
+```
+
+
+It's important to note that `::` does not apply to every application of `initial()`.
+Primarily in cases where the type you're using for the initial value is not static.
+
+For example,
+```dm
+/proc/cmp_subsystem_init(datum/controller/subsystem/a, datum/controller/subsystem/b)
+	return initial(b.init_order) - initial(a.init_order)
+```
+could not use `::` as the provided types are not static.
+
 ## Procs
 
 ### Getters and setters
@@ -399,7 +440,7 @@ Pop-quiz, what does this do?
 give_pizza(TRUE, 2)
 ```
 
-Well, obviously the `TRUE` makes the pizza hot, and `2` is the number of toppings. 
+Well, obviously the `TRUE` makes the pizza hot, and `2` is the number of toppings.
 
 Code like this can be very difficult to read, especially since our LSP does not show argument names at this time. Because of this, you should prefer to use named arguments where the meaning is not otherwise obvious.
 
@@ -549,7 +590,7 @@ This is [a real bug that tends to come up](https://github.com/tgstation/tgstatio
 The same goes for arguments passed to a macro...
 
 ```
-// Guarantee 
+// Guarantee
 #define CALCULATE_TEMPERATURE(base) (T20C + (##base))
 ```
 

.github/images/README.md

@@ -0,0 +1,8 @@
+# Attributions
+
+## Badges
+`built-with-resentment.svg` and `contains-technical-debt.svg` were originally sourced from https://forthebadge.com/, with the repository located at https://github.com/BraveUX/for-the-badge. `made-in-byond.gif` is a user-generated modification of one of these badges provided by this service.
+
+## Comics
+
+Both comics are sourced from https://www.monkeyuser.com/, which gives permission for use in non-profit usage via https://www.monkeyuser.com/about/index.html. `bug_free.png` can be found at https://www.monkeyuser.com/2019/bug-free/, and the original version of `technical_debt.png` can be found at https://www.monkeyuser.com/2018/tech-debt/ (the version found in the folder has been modified).