Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tramstation random failure cherrypick #359

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Tramstation random failure cherrypick #359

merged 2 commits into from
Oct 18, 2023

Conversation

MrMelbert
Copy link
Owner

LemonInTheDark and others added 2 commits October 18, 2023 13:39
@LemonInTheDark @MrMelbert
Properly unreg's turf changed when space openspace is deleted (76501)
4b60070 
Openspace tracks the turf below for starlight purposes The trouble is if
a turf is replaced by another, all its signal registers still persist

I forgot about this, so we'd get runtimes when a
/turf/open/space/openspace was replaced, and the turf below it changed

Less random runtimes

(cherry picked from commit cfc4e96)
@MrMelbert
A
c6a7b1b
@MrMelbert MrMelbert added the Maintenance Little spring cleaning never done anyone wrong label Oct 18, 2023
@MrMelbert MrMelbert merged commit e08c63e into master Oct 18, 2023
20 checks passed
@MrMelbert MrMelbert deleted the cherrypick_76501 branch October 18, 2023 23:04
@MrMelbert MrMelbert added the Cherry Picked We're behind on schedule; and this is something we fucking need label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cherry Picked We're behind on schedule; and this is something we fucking need Maintenance Little spring cleaning never done anyone wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrMelbert @LemonInTheDark