Skip to content

Commit

Permalink
Borgs: the moduling (Various fixups to borg module code) (#83116)
Browse files Browse the repository at this point in the history
- Gets rid of the item addition copypaste code (Why nobody did this for
7 years is beyond me)
- Adds variable and proper checks for if a module is already installed
(Borgs will no longer eat up unlimited masses of lavaproof track
upgrades, among others) (Technically this never allows duplicates, at
least currently, as I don't recall any modules being capable to used
multiple times intentionally without also deleting themselves with
single_use)
 - Unsingleletters most if not all of `robot_upgrades.dm`

Makes the borg module code much cleaner, makes it significantly easier
for new ones to be added. Fixes unintended behaviour with some modules
being able to stack, which until now was always solved by copypasting
code.

:cl:
fix: Fixed some borg modules just being constantly eaten up by borgs
even when they shouldn't allow duplicates
refactor: Borg module code now has better handling for adding/removing
items, and to prevent duplicate module usage (Unless one wishes to
override the behaviour.
/:cl:

---------

Co-authored-by: Ghom <[email protected]>
Co-authored-by: san7890 <[email protected]>
  • Loading branch information
3 people authored and Constellado committed Dec 25, 2024
1 parent ccc7365 commit b9f3c43
Show file tree
Hide file tree
Showing 3 changed files with 299 additions and 490 deletions.
2 changes: 1 addition & 1 deletion code/game/objects/effects/spawners/random/exotic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
/obj/item/storage/medkit/brute = 27,
/obj/item/storage/medkit/fire = 27,
/obj/item/storage/toolbox/syndicate = 12,
/obj/item/borg/upgrade/ddrill = 3,
/obj/item/borg/upgrade/diamond_drill = 3,
/obj/item/knife/butcher = 14,
/obj/item/clothing/glasses/night = 10,
/obj/item/pickaxe/drill/diamonddrill = 6,
Expand Down
Loading

0 comments on commit b9f3c43

Please sign in to comment.