Skip to content

Commit

Permalink
Apply clean-up suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: MrMelbert <[email protected]>
  • Loading branch information
Wollywoger and MrMelbert authored Nov 15, 2024
1 parent 403f690 commit 1f72a8b
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@
/datum/crafting_recipe/volite_amulet
name = "Volite Amulet"
result = /obj/item/clothing/neck/mana_star
reqs = list(/obj/item/mana_battery/mana_crystal/cut = 1,
/obj/item/stack/sheet/mineral/gold = 1, // cheap for now
)
reqs = list(
/obj/item/mana_battery/mana_crystal/cut = 1,
/obj/item/stack/sheet/mineral/gold = 1, // cheap for now
)
tool_behaviors = list(TOOL_SCREWDRIVER)
time = 5 SECONDS
category = CAT_EQUIPMENT
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ GLOBAL_LIST_EMPTY_TYPED(all_leylines, /datum/mana_pool/leyline)

/proc/get_initial_leyline_amount()
var/list/leyline_amount_list = list(
"1" = 5000,
"2" = 500,
"3" = 200,
"4" = 10
"1" = 5000,
"2" = 500,
"3" = 200,
"4" = 10
)
var/leyline_amount = text2num(pick_weight(leyline_amount_list))
return leyline_amount
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
pre_use_check_comsig,
post_use_comsig = COMSIG_SPELL_TOUCH_HAND_HIT,
datum/callback/mana_required,
list/datum/attunement/attunements
)
list/datum/attunement/attunements,
)

..()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
desc = "Summon an ice knife made from the moisture in the air."
button_icon = 'maplestation_modules/icons/mob/actions/actions_cantrips.dmi'
button_icon_state = "ice_knife"
/// What the mana cost is, affected by Armblade variant.
/// What the mana cost is, affected by Armblade variant.
var/mana_cost = ICE_KNIFE_MANA_COST
item_type = /obj/item/knife/combat/ice
delete_old = TRUE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
mana_required = shock_touch_cost, \
get_user_callback = CALLBACK(src, PROC_REF(get_owner)), \
attunements = attunements, \
)
)

// Shock mutation needs to address people with magic shock touch
/datum/mutation/human/shock
Expand Down

0 comments on commit 1f72a8b

Please sign in to comment.