Node/EffectInstance: fix setting the frame range from readers

MrKepzie · Jan 24, 2017 · 24762ea · 24762ea
1 parent 7cc47d0
commit 24762ea
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/Engine/EffectInstance.cpp b/Engine/EffectInstance.cpp
@@ -4767,11 +4767,8 @@ EffectInstance::onKnobValueChanged_public(KnobI* k,
     // for image readers, image writers, and video writers, frame range must be updated before kOfxActionInstanceChanged is called on kOfxImageEffectFileParamName
     bool mustCallOnFileNameParameterChanged = false;
     if ( (reason != eValueChangedReasonTimeChanged) && ( isReader() || isWriter() ) && (k->getName() == kOfxImageEffectFileParamName) ) {
-        if ( isVideoReader() ) {
-            mustCallOnFileNameParameterChanged = true;
-        } else {
-            node->onFileNameParameterChanged(k);
-        }
+        node->computeFrameRangeForReader(k);
+        mustCallOnFileNameParameterChanged = true;
     }
 
     bool ret = false;

diff --git a/Engine/Node.cpp b/Engine/Node.cpp
@@ -900,15 +900,6 @@ Node::load(const CreateNodeArgs& args)
         assert(_imp->effect);
     }
 
-
-    // For readers, set their original frame range when creating them
-    if ( !serialization && ( _imp->effect->isReader() || _imp->effect->isWriter() ) ) {
-        KnobPtr filenameKnob = getKnobByName(kOfxImageEffectFileParamName);
-        if (filenameKnob) {
-            onFileNameParameterChanged( filenameKnob.get() );
-        }
-    }
-
     _imp->effect->initializeOverlayInteract();
 
 
@@ -8058,8 +8049,6 @@ void
 Node::onFileNameParameterChanged(KnobI* fileKnob)
 {
     if ( _imp->effect->isReader() ) {
-        computeFrameRangeForReader(fileKnob);
-
         ///Refresh the preview automatically if the filename changed
         incrementKnobsAge(); //< since evaluate() is called after knobChanged we have to do this  by hand
         //computePreviewImage( getApp()->getTimeLine()->currentFrame() );