Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for engine modules and permissions #5264

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Spoorthy1423
Copy link

#4647 Added Document on how and when to add classes/permissions/packages to engine module

-Added markdown and clearly stated requirements

Contains

Brief description of what the PR does like "Fixes #12345"

How to test

Brief description of how to test / confirm this PR before merging

Outstanding before merging

If anything. You can use neat checkboxes! Feel free to delete if not needed

  • Need to consider use case x
  • Still have to adjust the wiki doc
  • Will need translation work

@BenjaminAmos
Copy link
Contributor

This seems incomplete and unfortunately does not make much sense. Did you try to read through and understand the codebase before writing this? Also, please try and fill-out the pull request template. It helps when trying to understand what this is at a glance.

If this is not ready for review yet, you can mark it as a draft so that others will know to leave it be until you mark it as ready again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants