-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove usage of RegisterCopyStrategy #50
base: master
Are you sure you want to change the base?
Conversation
This is using at engine itself. :) |
Recapping my thoughts after that brief discussion:
|
I looked through module space and these are the only instances these annotations are used for. more inclined to drop them so there is no pretense that the annotation is used anywhere. more confusing to have them then not have them. If were not using them for registration then what do they serve :?. just as easy to add them back in if we need to have some kind of registration process for copying properties in module space but at the moment just make things complicated. |
I didn't feel like switching to this branch to get the Vector4i strategy, so I did this instead: MovingBlocks/Terasology@9afe704 but that really doesn't solve the question of whether to keep the annotation or which of our various several packages these CopyStrategies should live in. |
@keturn the annotation is unnecessary and complicates things so I would opt to remove it. in terms of where this fits, probably in gestalt as some kind of utility copy library of sorts. |
I was looking at the usage and I don't see any kind of registration in module space. not sure what this serves at the moment to have things registered in this fashion. At the moment we can bind things the same way we bind things such as TypeHandlers and they are not driven by scanning for classes. If there is no immediate use for this in module space I propose dropping this.
If we are looking for more generic solutions I think this could be solved with (MovingBlocks/gestalt#87). not sure how to handle the generics thought. there is some existing mechanism to look at generics just not a way to look at it from the definition. maybe something to investigate down the line @DarkWeird .
ref Commit: MovingBlocks/Terasology@f9ce52f
MovingBlocks/Terasology#4593