Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing find function, fixes #564 #595

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dotnetCarpenter
Copy link
Contributor

@dotnetCarpenter dotnetCarpenter commented Jan 27, 2021

find is referenced in chapter 8 and is needed for the IO example:

// findParam :: String -> IO Maybe [String]
const findParam = key => map(compose(Maybe.of, find(compose(eq(key), head)), params), url);

This implementation of find only works for Array which is also the type of params in the example.
params :: String -> [[String]]

find is referenced in chapter 8 and is needed for the IO example:

// findParam :: String -> IO Maybe [String]
const findParam = key => map(compose(Maybe.of, find(compose(eq(key), head)), params), url);
@dotnetCarpenter
Copy link
Contributor Author

@KtorZ should I reinstate the white-spaces in appendix_c.md before this PR can be accepted?

@KtorZ
Copy link
Member

KtorZ commented Feb 19, 2021

@dotnetCarpenter no worries here. These are indeed extraneous. A double-whitespace marks a newline in markdown (probably should use an explicit <br> instead...) but in this case they are simply superfluous.

I've been busy with other stuff lately and didn't give much time to reviews which required more than a quick eye-check. I'll allocate some time soon-ish to go through some open PRs and issues on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants