test: Add tests for allow_paths configuration #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Nice! two nits:
- Clippy is failing
- The difference between the two tests is passing the allow_paths option right? So maybe you can just use a single test, where you set up the files once, try to compile without
allow_paths, check it fails, then add the allow_paths to the existing project then check it succeeds. I would think it's cleaner that way and also the difference between success/failure is made more evident (just the allow_paths option), but it might be subjective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.