Skip to content

Commit

Permalink
fix preview flickering when sending out DDP or art-net
Browse files Browse the repository at this point in the history
BusNetwork stores original colors (not modified by global brightness), so `restoreColorLossy(strip.getPixelColor(i), stripBrightness);`  was actually restoring brightness twice when running network output. This lead to preview flickering.
  • Loading branch information
softhack007 committed Dec 19, 2024
1 parent 87e6a7b commit 7b3b6b4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions wled00/ws.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ static bool sendLiveLedsWs(uint32_t wsClient) // WLEDMM added "static"
if ((i/Segment::maxWidth)%(n)) i += Segment::maxWidth * (n-1);
}
#endif
uint32_t c = restoreColorLossy(strip.getPixelColor(i), stripBrightness); // WLEDMM full bright preview - does _not_ recover ABL reductions
//uint32_t c = strip.getPixelColorRestored(i);
//uint32_t c = restoreColorLossy(strip.getPixelColor(i), stripBrightness); // WLEDMM full bright preview - does _not_ recover ABL reductions
uint32_t c = strip.getPixelColorRestored(i);
// WLEDMM begin: preview with color gamma correction
if (gammaCorrectPreview) {
uint8_t w = W(c); // not sure why, but it looks better if using "white" without corrections
Expand Down

0 comments on commit 7b3b6b4

Please sign in to comment.