forked from roundcube/roundcubemail-docker
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from roundcube:master #39
Open
pull
wants to merge
111
commits into
Monogramm:master
Choose a base branch
from
roundcube:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and document recommended mount mounts in README
Merging PR for further development
Fixes #204
* Include unzip package to avoid composer warnings * Separate actions to test and publish * Exclude builds on changes to README.md and examples
+ clean-up yaml syntax
Co-authored-by: Julien Janier <[email protected]>
Closes issue #212
They might be required by other packages that people building derived container images might want to install.
Previously the branch was created and pushed no matter if changes were committed, which made subsequent runs fail. This is fixed by using distinctly named branches, and by exiting early if no changes are to be committed.
ISO8601 contains colons, which apparently are not allowed for git branch names.
f1bba7f removed it from apache/Dockerfile only, which even gets overwritten by update.sh
Co-authored-by: Björn Bores <[email protected]>
They hint on a possibility that isn't fleshed out, and mislead people to think something is broken because HTTPS doesn't work out of the box.
Apparently there were problems with running new versions some time ago, but I couldn't reproduce them, so here we go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )