feat: add support for AWS Web Identity auth flow #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new fields SASLAWSWebIdentityRoleArn, SASLAWSWebIdentityToken, and SASLAWSWebIdentityTokenFilePath to the Kafka configuration. This enables authentication using AWS Web Identity Role for generating auth tokens.
Updated the function call from `GenerateAuthTokenFromWebIdentityRole` to `GenerateAuthTokenFromWebIdentity`. This resolves mismatched function signature issues and ensures proper authentication workflow.
Rename SASLAWSWebIdentityTokenFilePath to SASLAWSWebIdentityTokenFile for consistency and clarity. Adjust related logic to reflect the new field name.
Removed the redundant SASLAWSWebIdentityRoleArn field and reorganized the conditional logic for token generation. This change streamlines the code and ensures proper role handling.
Sensitive fields in the SASL configuration are now masked. This prevents inadvertent exposure of credentials and tokens in logs.
Added new schema fields for 'sasl_aws_web_identity_token' and 'sasl_aws_web_identity_token_file' to support AWS Web Identity Token authentication. Updated the Kafka provider configuration accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new schema fields for 'sasl_aws_web_identity_token' and 'sasl_aws_web_identity_token_file' to support AWS Web Identity Token authentication. Updated the Kafka provider configuration accordingly.
Utilized function to generate auth token from web identity (
signer.GenerateAuthTokenFromWebIdentity) which is declared in aws/aws-msk-iam-sasl-signer-go#21