Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code and fix bugs #1

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Update code and fix bugs #1

wants to merge 11 commits into from

Conversation

RlyehAD
Copy link

@RlyehAD RlyehAD commented Dec 10, 2021

  1. The code has been updated to be consistent with the latest versions of mmelemental, cmselemental and mmic. This update provides a foundation for the packages using mmic_cmd to run smoothly.
  2. The CI tests can be passed. But there's still problems with the doc action.

TO DO

  1. Make the repo pass the doc processes.

@RlyehAD RlyehAD marked this pull request as draft December 10, 2021 20:24
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2021

This pull request fixes 1 alert when merging 4012d33 into 9039018 - view on LGTM.com

fixed alerts:

  • 1 for Wrong name for an argument in a call

@anabiman
Copy link
Collaborator

I would like to retain outfiles_track to make this applicable to processing large data files. For now, this component works only with a fork of QCEngine. Maybe the best way to get around this is by replicating the util.execute functionality from QCEngine in this component.

@anabiman
Copy link
Collaborator

I have moved some of the needed functionality from QCEngine to this pkg. The cmd component now works. Please update your PR accordingly @RlyehAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants