Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Grimme vDZP basis for wB97X-3c method #316

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

susilehtola
Copy link
Contributor

Closes #266

@marcelmbn
Copy link

Is there anything I could still help with from my/our side? Or are there more technical reasons on the BSE side (CI etc.) that stand in the way of merging the PR?

@jevandezande
Copy link

@bennybp, is there anything that I can do to help get this merged in? What stands in the way of merging this PR?

@bennybp
Copy link
Member

bennybp commented Sep 18, 2024

Sorry, this one slipped under my radar! I had been traveling for a good chunk of August.

The only modification need was renaming the data file so the tests pass (which I've done).

@bennybp bennybp merged commit 4fabcd5 into MolSSI-BSE:master Sep 18, 2024
17 checks passed
@marcelmbn
Copy link

Thank you for the last changes and for merging the code! Just a quick question – is there a release or similar required until the basis set can be downloaded from https://www.basissetexchange.org/? Or is this an automatic process?

@susilehtola susilehtola deleted the vdzp branch September 19, 2024 07:06
@susilehtola
Copy link
Contributor Author

Thank you for the last changes and for merging the code! Just a quick question – is there a release or similar required until the basis set can be downloaded from https://www.basissetexchange.org/? Or is this an automatic process?

Yes, the website is only updated once a new stable release has been made. For immediate access to the basis set, please clone the master branch of the git repo and use the command line utilities to get the basis sets in the wanted format.

@marcelmbn
Copy link

Thank you for the last changes and for merging the code! Just a quick question – is there a release or similar required until the basis set can be downloaded from https://www.basissetexchange.org/? Or is this an automatic process?

Yes, the website is only updated once a new stable release has been made. For immediate access to the basis set, please clone the master branch of the git repo and use the command line utilities to get the basis sets in the wanted format.

As long as it will be part of the next stable release and the work is basically done, that's fine. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vDZP basis
4 participants