Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider arguments when literal is impermissible #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Consider arguments when literal is impermissible #88

wants to merge 1 commit into from

Conversation

hugmanrique
Copy link

@hugmanrique hugmanrique commented Apr 3, 2021 •
edited
Loading

Fixes #87

@ghost
Copy link

ghost commented Apr 3, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

MoritzR200
MoritzR200 approved these changes Jul 13, 2022
View reviewed changes
Copy link

@MoritzR200 MoritzR200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an great change that adds further possibilities to this Framework in an expected manner.
Effectively the changes only resolve an issue, that is unintuitive to the end-user and instead returns the expected result.

The changes themself are implemented very reasonably and Tests are added which both show why this change is needed and ensure, that nothing breaks because of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoritzR200 MoritzR200 MoritzR200 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argument node is not considered when literal is impermissible with same name
2 participants
@hugmanrique @MoritzR200