Small fixes for recursive data fixers #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using the unfolded type instead of the recursive point, a fixer applying to that type will rewrite the entire type without a fold, causing it to only fix the top-level.
…vely This type is used to encode the Typed structure to data, and matches the type that the fixer actually gets passed. Otherwise, we try to encode the sub-values with the old format, which fails.
fry-mojang
previously approved these changes
Jan 22, 2024
billybong
approved these changes
Jan 23, 2024
Fantastime
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small issues:
DataFixerUpperon some recursive root type, and there is a data fixer that fixes that root type, that type will not be recursively fixed.writeFixAndRead/writeAndReadwith a recursive type, the fixer function itself is invoked with sub-types already upgraded; but we try to parse this typed structure with the input type. We need to instead 'patch' those sub-types to the new types within the input type.TypeRewriteRulealready knows how to do that, so we can capture the type from this.