Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in huggingface adapter. #288

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BlueCrescent
Copy link
Collaborator

What does this PR do?

Fixed error caused by changes to transformer library. Also added skip conditions for hf adapter tests so that they are less likely to be skipped.

General Changes

  • Error fix
  • Modified skip condition for corresponding tests:
    • Only 1 GPU required instead of 2 GPUs and RANK environment variable being set.

Checklist before submitting final PR

  • My PR is minimal and addresses one issue in isolation
  • I have merged the latest version of the target branch into this feature branch
  • I have reviewed my own code w.r.t. correct implementation, missing type hints, proper documentation, etc.
  • I have run a sample config for model training
  • I have checked that all tests run through (python tests/tests.py)
  • I have updated the internal changelog (CHANGELOG_DEV.md)

Fixed error caused by changes to transformer library.
Also added skip conditions for hf adapter tests so that they are less likely to be skipped.
@BlueCrescent BlueCrescent requested a review from fromm-m January 10, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant