Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - make setup_logging independent #166

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Dec 9, 2024

Change Summary

  • make setup_logging independent and move to syncmaster.settings.log:
    • now worker doesn't need backend python dependencies as it imports from root settings
    • reduce duplicated code for logging setup
  • update worker dependencies

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Dec 9, 2024
@maxim-lixakov maxim-lixakov self-assigned this Dec 9, 2024
@maxim-lixakov maxim-lixakov requested review from IlyasDevelopment and dolfinus and removed request for IlyasDevelopment December 9, 2024 15:16
@maxim-lixakov maxim-lixakov merged commit 60ab590 into develop Dec 9, 2024
19 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/update_worker branch December 9, 2024 16:04
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (ffe0180) to head (8869f10).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #166   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants