Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-13016] - add namespace_history table and its api methods #24

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Feb 26, 2024

Change Summary

  • Add Namespace History model to track namespaces' changes.
  • Remove is_deleted field from Namespace table. Now data about deleted namespaces is stored in Namespace History table in column action.
  • Add v1/namespace-history/ api method to receive paginated namespace history. Add endpoint request to method in backend sync client.
  • Delete is_deleted field in User model.
  • Update following tests and documentation.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.42%. Comparing base (92d8c88) to head (d2d11e2).

Files Patch % Lines
...db/migrations/versions/2024-02-27_5c7a5c5a193b_.py 77.77% 4 Missing ⚠️
...db/migrations/versions/2024-02-27_2452f82ae06c_.py 91.66% 1 Missing ⚠️
horizon/backend/services/uow.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    89.29%   89.42%   +0.12%     
===========================================
  Files          104      109       +5     
  Lines         1981     2061      +80     
  Branches       181      179       -2     
===========================================
+ Hits          1769     1843      +74     
- Misses         167      174       +7     
+ Partials        45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-lixakov maxim-lixakov marked this pull request as ready for review February 26, 2024 14:35
@maxim-lixakov maxim-lixakov self-assigned this Feb 26, 2024
@maxim-lixakov maxim-lixakov merged commit ca92995 into develop Feb 27, 2024
16 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-13016 branch February 27, 2024 12:42
maxim-lixakov added a commit that referenced this pull request Mar 27, 2024
* [DOP-13016] - add namespace_history table and its api methods

* Update docs/changelog/next_release/24.feature.rst

Co-authored-by: Maxim Martynov <[email protected]>

* [DOP-13016] - add namespace history client docs

* [DOP-13016] - drop 'is_delete' field for User

* [DOP-13016] - add migration for user

---------

Co-authored-by: Maxim Martynov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants