Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep scheme sorting info in rsync #2829

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Keep scheme sorting info in rsync #2829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xcodeproj/internal/templates/legacy_installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ rsync \
--chmod=u+w,F-x \
--exclude=project.xcworkspace \
--exclude=rules_xcodeproj/bazel \
--exclude=xcuserdata \
--exclude="*.xcbkptlist" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User created schemes should be left alone as well. Probably better to leave this exclude as is, and copy over the schememanagement file, similar to the incremental installer?

rules_xcodeproj/xcodeproj/internal/templates/incremental_installer.sh

Lines 138 to 142 in 4f68608

# Copy over `xcschememanagement.plist`
username="$(/usr/bin/id -un)"
readonly username
readonly user_xcschmes="$dest/xcuserdata/$username.xcuserdatad/xcschemes"
readonly dest_xcschememanagement="$user_xcschmes/xcschememanagement.plist"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, let me update this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongjincho92 Any progress on this?

--delete \
"$src/" "$dest/"

Expand Down
Loading