relayer skips error on message relaying #154
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
kernel/internal/clock/time.go#L13
kernel/internal/clock/time.go:13: Line contains TODO/BUG/FIXME: "FIXME GLOBAL VARIABLES" (godox)
|
|
lint:
go.mod#L5
replacement are not allowed: github.com/dgraph-io/badger/v4 (gomoddirectives)
|
|
lint:
kernel/internal/clock/time.go#L9
import 'github.com/MixinNetwork/mixin/config' is not allowed from list 'Main' (depguard)
|
|
lint:
kernel/internal/clock/time.go#L10
import 'github.com/MixinNetwork/mixin/logger' is not allowed from list 'Main' (depguard)
|
|
lint:
kernel/internal/clock/time.go#L23
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"clock reset not allowed in build version %s\", config.BuildVersion)" (err113)
|
|
lint:
kernel/internal/clock/time.go#L33
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"clock mock not allowed in build version %s\", config.BuildVersion)" (err113)
|
|
lint:
kernel/internal/clock/time.go#L16
inTest is a global variable (gochecknoglobals)
|
|
lint:
kernel/internal/clock/time.go#L17
mutex is a global variable (gochecknoglobals)
|
|
lint:
kernel/internal/clock/time.go#L18
mockDiff is a global variable (gochecknoglobals)
|
|
lint:
kernel/internal/clock/time.go#L49
return with no blank line before (nlreturn)
|
|
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
storage/interface.go#L33
var-naming: interface method parameter nodeIdWithNetwork should be nodeIDWithNetwork (revive)
|
|
lint:
storage/interface.go#L48
var-naming: interface method parameter nodeId should be nodeID (revive)
|
|
lint:
storage/interface.go#L51
var-naming: interface method parameter nodeId should be nodeID (revive)
|
|
lint:
storage/badger_validation.go#L17
var-naming: method parameter networkId should be networkID (revive)
|
|
lint:
storage/badger_transaction.go#L230
var-naming: func parameter nodeId should be nodeID (revive)
|