rpc header vary origin for better cdn cache #189
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
util/base58/doc.go#L9
File is not `gofmt`-ed with `-s` (gofmt)
|
|
lint:
go.mod#L5
replacement are not allowed: github.com/dgraph-io/badger/v4 (gomoddirectives)
|
|
lint:
util/base58/base58.go#L36
Duplicate words (j) found (dupword)
|
|
lint:
util/base58/base58.go#L13
bigRadix is a global variable (gochecknoglobals)
|
|
lint:
util/base58/base58.go#L27
bigRadix10 is a global variable (gochecknoglobals)
|
|
lint:
util/base58/base58.go#L15
Magic number: 58, in <argument> detected (gomnd)
|
|
lint:
util/base58/base58.go#L16
Magic number: 58, in <argument> detected (gomnd)
|
|
lint:
util/base58/base58.go#L17
Magic number: 58, in <argument> detected (gomnd)
|
|
lint:
util/base58/base58.go#L97
Magic number: 1.365658237309761, in <argument> detected (gomnd)
|
|
lint:
util/base58/base58check.go#L29
Magic number: 4, in <argument> detected (gomnd)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
storage/badger_validation.go#L73
increment-decrement: should replace total += 1 with total++ (revive)
|
|
lint:
storage/badger_validation.go#L88
increment-decrement: should replace invalid += 1 with invalid++ (revive)
|
|
lint:
storage/badger_validation.go#L108
increment-decrement: should replace invalid += 1 with invalid++ (revive)
|
|
lint:
storage/badger_graph.go#L58
increment-decrement: should replace removed += 1 with removed++ (revive)
|
|
lint:
storage/badger_validation.go#L118
increment-decrement: should replace invalid += 1 with invalid++ (revive)
|
|
lint:
storage/badger_work.go#L153
increment-decrement: should replace wm[si] += 1 with wm[si]++ (revive)
|
|
lint:
storage/badger_transaction.go#L230
var-naming: func parameter nodeId should be nodeID (revive)
|
|
lint:
storage/interface.go#L33
var-naming: interface method parameter nodeIdWithNetwork should be nodeIDWithNetwork (revive)
|
|
lint:
storage/interface.go#L48
var-naming: interface method parameter nodeId should be nodeID (revive)
|
|
lint:
storage/interface.go#L51
var-naming: interface method parameter nodeId should be nodeID (revive)
|