upgrade quic go module #187
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
crypto/blake2b_test.go#L58
Error return value of `x.Read` is not checked (errcheck)
|
|
lint:
crypto/batch.go#L91
Function 'Verify' is too long (72 > 60) (funlen)
|
|
lint:
crypto/cosi_test.go#L11
Function 'TestCosi' has too many statements (66 > 40) (funlen)
|
|
lint:
crypto/signature_test.go#L18
Function 'testSignature' has too many statements (50 > 40) (funlen)
|
|
lint:
crypto/key.go#L107
captLocal: `A' should not be capitalized (gocritic)
|
|
lint:
crypto/key.go#L120
captLocal: `R' should not be capitalized (gocritic)
|
|
lint:
crypto/key.go#L132
captLocal: `P' should not be capitalized (gocritic)
|
|
lint:
crypto/hash_test.go#L50
assignOp: replace `msg = msg + msg` with `msg += msg` (gocritic)
|
|
lint:
crypto/batch.go#L32
Comment should end in a period (godot)
|
|
lint:
crypto/cosi.go#L51
the line is 121 characters long, which exceeds the maximum of 120 characters. (lll)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
common/custodian_test.go#L14
var-naming: const mainnetId should be mainnetID (revive)
|
|
lint:
common/custodian_test.go#L128
var-naming: var nodeId should be nodeID (revive)
|
|
lint:
common/custodian_test.go#L163
unused-parameter: parameter 'require' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
common/round.go#L15
var-naming: struct field NodeId should be NodeID (revive)
|