only use precommitements for active peer connections #180
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
kernel/internal/testing.go#L14
don't use `init` function (gochecknoinits)
|
|
lint:
kernel/internal/testing.go#L6
import 'github.com/MixinNetwork/mixin/config' is not allowed from list 'Main' (depguard)
|
|
lint:
kernel/internal/testing.go#L10
inTest is a global variable (gochecknoglobals)
|
|
lint:
kernel/internal/testing.go#L11
mockRunAggregators is a global variable (gochecknoglobals)
|
|
lint:
common/encoding.go#L314
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
common/encoding.go#L329
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
common/encoding.go#L341
Error return value of `enc.WriteByte` is not checked (errcheck)
|
|
lint:
common/custodian.go#L147
Function 'validateCustodianUpdateNodes' has too many statements (44 > 40) (funlen)
|
|
lint:
common/decoding.go#L31
Function 'DecodeSnapshotWithTopo' has too many statements (47 > 40) (funlen)
|
|
lint:
common/decoding.go#L102
Function 'DecodeTransaction' has too many statements (65 > 40) (funlen)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
common/asset.go#L11
var-naming: var XINAssetId should be XINAssetID (revive)
|
|
lint:
common/custodian_test.go#L163
unused-parameter: parameter 'require' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
common/asset.go#L12
var-naming: var BitcoinAssetId should be BitcoinAssetID (revive)
|
|
lint:
common/custodian_test.go#L14
var-naming: const mainnetId should be mainnetID (revive)
|
|
lint:
common/asset.go#L13
var-naming: var EthereumAssetId should be EthereumAssetID (revive)
|
|
lint:
common/asset.go#L14
var-naming: var BOXAssetId should be BOXAssetID (revive)
|
|
lint:
common/custodian_test.go#L128
var-naming: var nodeId should be nodeID (revive)
|
|
lint:
common/asset.go#L15
var-naming: var MOBAssetId should be MOBAssetID (revive)
|
|
lint:
common/asset.go#L16
var-naming: var USDTEthereumAssetId should be USDTEthereumAssetID (revive)
|
|
lint:
common/asset.go#L17
var-naming: var USDTTronAssetId should be USDTTronAssetID (revive)
|