-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples: Improve consistency of description panel manipulation (#104) #930
base: main
Are you sure you want to change the base?
Samples: Improve consistency of description panel manipulation (#104) #930
Conversation
Fixes #104 I tried all affected scenes in Editor and on a Magic Leap 2 device |
…RealityToolkit#104) * Allow DescriptionPanel to be consistently grabbed in order to move the main scene content for that sample. - Update the DescriptionPanel prefab to include ObjectManipulator, UGUIInputAdapterDraggable, ConstraintManager and a BoxCollider. * Update all scenes that reference DescriptionPanel to remove component duplication. * Reference the parent "MixedRealitySceneContent" game object as the host transform when DescriptionPanels are moved. * Removed some inconsistencies around game objects named "MixedRealitySceneContent", "SceneContent", "Content", "Examples", "Scene Content" to all be "MixedRealitySceneContent". * Add a rotation constraint to LegacyConstraintExamples scene content such that the content is always gravity aligned even after being moved via the description panel.
a2e96e7
to
a45258b
Compare
(Rebased on top of latest main) |
@ghazen-ml , please check on merge conflicts with XRI3 branch before completing this PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve pending first making sure there aren't major merge conflicts with XRI3 branch
Unfortunately there do appear to be conflicts in each modified scene file. One option could be to instead make this change on the XRI3 branch and leave it there, or I could resolve the merge conflicts by re-applying the changes to each scene semi-manually. |
Allow DescriptionPanel to be consistently grabbed in order to move the main scene content for that sample.
Update all scenes that reference DescriptionPanel to remove component duplication.
Reference the parent "MixedRealitySceneContent" game object as the host transform when DescriptionPanels are moved.
Removed some inconsistencies around game objects named "MixedRealitySceneContent", "SceneContent", "Content", "Examples", "Scene Content" to all be "MixedRealitySceneContent".
Add a rotation constraint to LegacyConstraintExamples scene content such that the content is always gravity aligned even after being moved via the description panel.
Fixes #104