Updated ConstantViewSize solver to retain the initial scale and aspect ratio (Fixes #306) #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e as set by the Solver base class
BenediktTobias
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AMollis
reviewed
May 14, 2024
| protected override void Awake() | ||
| { | ||
| base.Awake(); | ||
| originalScale = GoalScale; |
There was a problem hiding this comment.
I don't have enough context on the original intent here.
@keveleigh or @david-c-kline , how do you feel about this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
The ConstantViewSize solver now retains the original scale and aspect ratio as set by the base class Solver instead of using Vector3.one as the base scale.