m.domFor(): workaround for unintentional mangling. Fix #2842

[kfule]

Refactoring of domFor() for the internal bundler.

Description

#2842 appears to be caused by a combination of the mangling of the internal bundler and the parameter destructuring of domFor().

mithril.js/mithril.js

Line 157 in cfa890f

function *domFor1({dom, domSize0}, {generation0} = {}) {

This pr avoids the parameter destructuring to fix the issue.

Motivation and Context

fix #2842

How Has This Been Tested?

Observing behavior of reproduction codes on the flems (#2842 (comment)) by replacing with the generated mithril.(min.)js.
Of course, npm run test has passed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My change requires a documentation update, and I've opened a pull request to update it already:
• I have read https://mithril.js.org/contributing.html.

[JAForbes]

Thanks @kfule, great find.

Approved, but I think a comment above the change referencing this PR would be useful. As my first thought would be to replace that logic with destructuring if I didn't know better.

[kfule]

@JAForbes
I've added a comment, could you please check it out.

[kfule]

@JAForbes Sorry, I found another destructuring in domFor(). This is not related to the bug, but it would be better to change it to keep the code consistency.

[JAForbes]

Thanks @kfule, I'll leave this for a day to give @MithrilJS/admins a chance to take a view, but if no objections after that we'll merge it 👍