added mutex for access to m_handshake everywhere except count requests

MitchellMarx · Jan 21, 2015 · 4b7b53b · 4b7b53b
1 parent bc5b0a0
commit 4b7b53b
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 21 deletions.
diff --git a/Lidgren.Network/NetPeer.Internal.cs b/Lidgren.Network/NetPeer.Internal.cs
@@ -340,26 +340,32 @@ private void Heartbeat()
 				// do handshake heartbeats
 				if ((m_frameCounter % 3) == 0)
 				{
-					foreach (var kvp in m_handshakes)
+					if (m_handshakes.Count > 0)
 					{
-						NetConnection conn = kvp.Value as NetConnection;
+						lock (m_handshakes)
+						{
+							foreach (var kvp in m_handshakes)
+							{
+								NetConnection conn = kvp.Value as NetConnection;
 #if DEBUG
-						// sanity check
-						if (kvp.Key != kvp.Key)
-							LogWarning("Sanity fail! Connection in handshake list under wrong key!");
+								// sanity check
+								if (kvp.Key != kvp.Key)
+									LogWarning("Sanity fail! Connection in handshake list under wrong key!");
 #endif
-						conn.UnconnectedHeartbeat(now);
-						if (conn.m_status == NetConnectionStatus.Connected || conn.m_status == NetConnectionStatus.Disconnected)
-						{
+								conn.UnconnectedHeartbeat(now);
+								if (conn.m_status == NetConnectionStatus.Connected || conn.m_status == NetConnectionStatus.Disconnected)
+								{
 #if DEBUG
-							// sanity check
-							if (conn.m_status == NetConnectionStatus.Disconnected && m_handshakes.ContainsKey(conn.RemoteEndPoint))
-							{
-								LogWarning("Sanity fail! Handshakes list contained disconnected connection!");
-								m_handshakes.Remove(conn.RemoteEndPoint);
-							}
+									// sanity check
+									if (conn.m_status == NetConnectionStatus.Disconnected && m_handshakes.ContainsKey(conn.RemoteEndPoint))
+									{
+										LogWarning("Sanity fail! Handshakes list contained disconnected connection!");
+										m_handshakes.Remove(conn.RemoteEndPoint);
+									}
 #endif
-							break; // collection has been modified
+									break; // collection has been modified
+								}
+							}
 						}
 					}
 				}
@@ -710,7 +716,8 @@ private void ReceivedUnconnectedLibraryMessage(double now, IPEndPoint senderEndP
 					// Ok, start handshake!
 					NetConnection conn = new NetConnection(this, senderEndPoint);
 					conn.m_status = NetConnectionStatus.ReceivedInitiation;
-					m_handshakes.Add(senderEndPoint, conn);
+					lock(m_handshakes)
+						m_handshakes.Add(senderEndPoint, conn);
 					conn.ReceivedHandshake(now, tp, ptr, payloadByteLength);
 					return;
 
@@ -729,8 +736,11 @@ internal void AcceptConnection(NetConnection conn)
 			// LogDebug("Accepted connection " + conn);
 			conn.InitExpandMTU(NetTime.Now);
 
-			if (m_handshakes.Remove(conn.m_remoteEndPoint) == false)
-				LogWarning("AcceptConnection called but m_handshakes did not contain it!");
+			lock (m_handshakes)
+			{
+				if (m_handshakes.Remove(conn.m_remoteEndPoint) == false)
+					LogWarning("AcceptConnection called but m_handshakes did not contain it!");
+			}
 
 			lock (m_connections)
 			{

diff --git a/Lidgren.Network/NetPeer.cs b/Lidgren.Network/NetPeer.cs
@@ -306,7 +306,8 @@ public virtual NetConnection Connect(IPEndPoint remoteEndPoint, NetOutgoingMessa
 				conn.m_connectRequested = true;
 				conn.m_connectionInitiator = true;
 
-				m_handshakes.Add(remoteEndPoint, conn);
+				lock(m_handshakes)
+					m_handshakes.Add(remoteEndPoint, conn);
 
 				return conn;
 			}

diff --git a/Samples/Chat/ChatClient/ChatClient.csproj b/Samples/Chat/ChatClient/ChatClient.csproj
@@ -61,7 +61,6 @@
       <DependentUpon>Resources.resx</DependentUpon>
       <DesignTime>True</DesignTime>
     </Compile>
-    <None Include="app.config" />
     <None Include="Properties\Settings.settings">
       <Generator>SettingsSingleFileGenerator</Generator>
       <LastGenOutput>Settings.Designer.cs</LastGenOutput>

diff --git a/Samples/Chat/ChatServer/ChatServer.csproj b/Samples/Chat/ChatServer/ChatServer.csproj
@@ -61,7 +61,6 @@
       <DependentUpon>Resources.resx</DependentUpon>
       <DesignTime>True</DesignTime>
     </Compile>
-    <None Include="app.config" />
     <None Include="Properties\Settings.settings">
       <Generator>SettingsSingleFileGenerator</Generator>
       <LastGenOutput>Settings.Designer.cs</LastGenOutput>