Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: use of issue-number on push when provided #177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

VincentAuriau
Copy link

@VincentAuriau VincentAuriau commented Jul 31, 2024

Changes:
When issue-number is provided it is used over the commit sha to define where the comment is made.

Why?
Basically I have an issue tracking all the improvements in the development of the tests in a repository - let's say covering the whole code is a long term objective. I wanted the action to regularly update the issue with the latest coverage statistics

Also:

  • I suppose it is a quiet uncommon objective and this behavior might be undesired, but still seemed logical to me not to ignore this input.
  • I am not sure about the code changes since I never used javascript and just copied/paster what seemed logical
  • I'd be happy to discuss the PR or improve the changes :)
  • I'm not sure why the diff has so many lines, I juste added a few lines, maybe vscode did some weird stuff.

ENH: use of issue-number on push
@VincentAuriau VincentAuriau deleted the enh/push branch July 31, 2024 22:07
@VincentAuriau VincentAuriau restored the enh/push branch July 31, 2024 22:08
@VincentAuriau VincentAuriau reopened this Jul 31, 2024
@VincentAuriau VincentAuriau changed the title Add: use of issue-number on push Add: use of issue-number on push when provided Jul 31, 2024
@VincentAuriau VincentAuriau changed the title Add: use of issue-number on push when provided ADD: use of issue-number on push when provided Aug 1, 2024
@MishaKav
Copy link
Owner

MishaKav commented Aug 1, 2024

Can you please to include all your changes in "sec/index.js" file. Because the "dist" - is only the output for build command.

@VincentAuriau
Copy link
Author

VincentAuriau commented Aug 1, 2024

It's done !
I'm not sure how I managed to do it with dist directory but somehow it worked.
I've copied the changes in src/index.js, I suppose it needs to be checked and dist/ rebuilt...

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants