Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOP-1572] Add etcd configuration and custom flag migration info #243

Merged
merged 13 commits into from
Jan 13, 2025
Merged

[BOP-1572] Add etcd configuration and custom flag migration info #243

merged 13 commits into from
Jan 13, 2025

Conversation

nsteph
Copy link
Collaborator

@nsteph nsteph commented Nov 23, 2024

This change adds:

  • etcd configuration page (similar to other Kube components)
  • subsections on the MKE 3 configuration migration docs that cover kubernetes custom flags and kubelet custom flag profiles

@nsteph nsteph requested a review from a team as a code owner November 23, 2024 22:01
KoryKessel-Mirantis
KoryKessel-Mirantis requested changes Dec 6, 2024
View reviewed changes
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
@nsteph
Copy link
Collaborator Author

nsteph commented Dec 11, 2024

@KoryKessel-Mirantis As discussed, I based the etcd pag on the existing MKE 3 docs, just changing the text to match the MKE 4 config and featureset.

The other sections (defrag/cleaning/alarm) describe features not yet implemented in MKE 4.

@KoryKessel-Mirantis KoryKessel-Mirantis self-assigned this Dec 17, 2024
@KoryKessel-Mirantis KoryKessel-Mirantis added this to the 4.0.1 milestone Dec 17, 2024
MagdaDziadosz
MagdaDziadosz requested changes Jan 13, 2025
View reviewed changes
content/docs/configuration/kubernetes/etcd.md Outdated Show resolved Hide resolved
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
KoryKessel-Mirantis and others added 2 commits January 13, 2025 14:32
@KoryKessel-Mirantis @MagdaDziadosz
Spacing fix.
4bf88d4 
Co-authored-by: Magdalena Dziadosz <[email protected]>
@KoryKessel-Mirantis @MagdaDziadosz
Add 's' to 'agree'.
43a4893 
Co-authored-by: Magdalena Dziadosz <[email protected]>
@KoryKessel-Mirantis KoryKessel-Mirantis merged commit e9ff65b into Mirantis:main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoryKessel-Mirantis KoryKessel-Mirantis KoryKessel-Mirantis approved these changes

@MagdaDziadosz MagdaDziadosz MagdaDziadosz approved these changes

Assignees

@KoryKessel-Mirantis KoryKessel-Mirantis

Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nsteph @KoryKessel-Mirantis @MagdaDziadosz