Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRODENG-2826 MCR Uninstall now swarm drains and prunes volumes #535

Merged
merged 1 commit into from
Jan 22, 2025
Merged

PRODENG-2826 MCR Uninstall now swarm drains and prunes volumes #535

merged 1 commit into from
Jan 22, 2025

Conversation

cranzy
Copy link
Contributor

@cranzy cranzy commented Jan 14, 2025 •
edited
Loading

  • Removes dangling volume upon mcr uninstall
  • Swarm drains the nodes on mcr uninstall

@cranzy cranzy force-pushed the 2826-drain-mcr-prune branch from 4f09053 to 1413100 Compare January 14, 2025 21:54
@cranzy cranzy force-pushed the 2826-drain-mcr-prune branch from 1413100 to 58e2b19 Compare January 14, 2025 22:41
@cranzy cranzy marked this pull request as ready for review January 14, 2025 22:49
@james-nesbitt
Copy link
Collaborator

Is docker treatment sufficient. Does this need to also consider the kubernetes layers?

@james-nesbitt
Copy link
Collaborator

this does not resolve #530 , rather it focuses on the reset command cleanup.

@cranzy
Copy link
Contributor Author

cranzy commented Jan 18, 2025

this does not resolve #530 , rather it focuses on the reset command cleanup.

This gh Issue wasn't linked anywhere in the ticket

@james-nesbitt
Copy link
Collaborator

This effort looks good. I ask only that you get the prune flag included in a smoke test to make the pattern tested.

@cranzy cranzy force-pushed the 2826-drain-mcr-prune branch from 58e2b19 to 8b5b13a Compare January 21, 2025 19:15
@cranzy cranzy force-pushed the 2826-drain-mcr-prune branch from 8b5b13a to a6b75e4 Compare January 21, 2025 19:29
@cranzy cranzy requested a review from james-nesbitt January 21, 2025 19:29
@cranzy
Copy link
Contributor Author

cranzy commented Jan 21, 2025

This effort looks good. I ask only that you get the prune flag included in a smoke test to make the pattern tested.

launchpad reset is ran regardless, so it will hit this feature

@cranzy cranzy merged commit fa856a2 into Mirantis:main Jan 22, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-nesbitt james-nesbitt james-nesbitt approved these changes

@pgedara pgedara Awaiting requested review from pgedara

@nekwar nekwar Awaiting requested review from nekwar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cranzy @james-nesbitt