Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #220

Closed
wants to merge 1 commit into from

Conversation

nwneisen
Copy link
Collaborator

@nwneisen nwneisen commented Aug 2, 2023

This PR is to fix the integration tests that are currently pinned to a working commit

#200

@nwneisen
Copy link
Collaborator Author

nwneisen commented Aug 7, 2023

Some additional context that I've found around this.

The tests are failing due to an already known issue, #213, with the container logs format using json-file format. A request was made to convert cri-dockerd to use the cri format for logs.

After digging into this, cri-dockerd is not doing much of anything with the logs. In fact, all it currently does is create a symlink in the pods directory to the log file that is created by docker.

I've started making changes that will instead read the contents from the docker logs file, change the format to CRI, and output the result to a new separate file in the pods folder.

@nwneisen nwneisen force-pushed the 200-fix-integration-tests branch 2 times, most recently from 736f618 to 2f3d126 Compare August 8, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants