Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added euclidean metric to basic backend #29

Merged
merged 5 commits into from
Dec 1, 2024
Merged

feat: Added euclidean metric to basic backend #29

merged 5 commits into from
Dec 1, 2024

Conversation

Pringled
Copy link
Member

No description provided.

@Pringled Pringled requested a review from stephantul November 29, 2024 12:45
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.09302% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
vicinity/backends/basic.py 71.76% 24 Missing ⚠️
Files with missing lines Coverage Δ
vicinity/vicinity.py 98.86% <100.00%> (+1.18%) ⬆️
vicinity/backends/basic.py 77.95% <71.76%> (-12.37%) ⬇️

stephantul
stephantul approved these changes Nov 30, 2024
View reviewed changes
vicinity/backends/basic.py Outdated Show resolved Hide resolved
vicinity/backends/basic.py Outdated Show resolved Hide resolved
@Pringled Pringled merged commit c5a3434 into main Dec 1, 2024
5 checks passed
@Pringled Pringled deleted the improve-metrics branch December 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephantul stephantul stephantul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pringled @codecov-commenter @stephantul