[build-logic] Bump checkstyle to 10.18.2

MiniDNS · Oct 20, 2024 · 90c4f88 · 90c4f88
1 parent 32caa88
commit 90c4f88
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/build-logic/src/main/groovy/org.minidns.java-conventions.gradle b/build-logic/src/main/groovy/org.minidns.java-conventions.gradle
@@ -151,7 +151,7 @@ jar {
 }
 
 checkstyle {
-	toolVersion = '8.27'
+	toolVersion = '10.18.2'
 
 	if (project in gplLicensedProjects) {
 		configProperties.checkstyleLicenseHeader = "${project.name}-gplv3-license-header"

diff --git a/minidns-async/src/main/java/org/minidns/source/async/AsyncNetworkDataSource.java b/minidns-async/src/main/java/org/minidns/source/async/AsyncNetworkDataSource.java
@@ -138,7 +138,7 @@ void cancelled(AsyncDnsRequest asyncDnsRequest) {
         SELECTOR.wakeup();
     }
 
-    private static class Reactor implements Runnable {
+    private static final class Reactor implements Runnable {
         @Override
         public void run() {
             while (!Thread.interrupted()) {

diff --git a/minidns-client/src/main/java/org/minidns/source/DnsDataSource.java b/minidns-client/src/main/java/org/minidns/source/DnsDataSource.java
@@ -40,7 +40,7 @@ public interface DnsDataSource {
      */
     void setTimeout(int timeout);
 
-    public interface OnResponseCallback {
+    interface OnResponseCallback {
         void onResponse(DnsMessage request, DnsQueryResult result);
     }
 

diff --git a/minidns-core/src/main/java/org/minidns/dnslabel/DnsLabel.java b/minidns-core/src/main/java/org/minidns/dnslabel/DnsLabel.java
@@ -235,12 +235,14 @@ public static String toSafeRepesentation(String dnsLabel) {
     }
 
     private static boolean isLdhOrMaybeUnderscore(char c, boolean underscore) {
+            // CHECKSTYLE:OFF
             return (c >= 'a' && c <= 'z')
                     || (c >= 'A' && c <= 'Z')
                     || (c >= '0' && c <= '9')
                     || c == '-'
                     || (underscore && c == '_')
                     ;
+            // CHECKSTYLE:ON
     }
 
     private static boolean consistsOnlyOfLdhAndMaybeUnderscore(String string, boolean underscore) {
@@ -265,7 +267,7 @@ public static boolean consistsOnlyOfLettersDigitsHypenAndUnderscore(String strin
     public static class LabelToLongException extends IllegalArgumentException {
 
         /**
-         * 
+         *
          */
         private static final long serialVersionUID = 1L;
 

diff --git a/minidns-core/src/main/java/org/minidns/record/Record.java b/minidns-core/src/main/java/org/minidns/record/Record.java
@@ -484,8 +484,8 @@ public String toString() {
      * @return True if this record is a valid answer.
      */
     public boolean isAnswer(Question q) {
-        return ((q.type == type) || (q.type == TYPE.ANY)) &&
-               ((q.clazz == clazz) || (q.clazz == CLASS.ANY)) &&
+        return (q.type == type || q.type == TYPE.ANY) &&
+               (q.clazz == clazz || q.clazz == CLASS.ANY) &&
                q.name.equals(name);
     }
 

diff --git a/minidns-dnssec/src/main/java/org/minidns/dnssec/DnssecClient.java b/minidns-dnssec/src/main/java/org/minidns/dnssec/DnssecClient.java
@@ -271,7 +271,7 @@ private Set<DnssecUnverifiedReason> verifyNsec(DnsMessage dnsMessage) throws IOE
         return result;
     }
 
-    private static class VerifySignaturesResult {
+    private static final class VerifySignaturesResult {
         boolean sepSignatureRequired = false;
         boolean sepSignaturePresent = false;
         Set<DnssecUnverifiedReason> reasons = new HashSet<>();