Diffy revamp #63
Open
Diffy revamp #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This looks like a great contribution. Sorry that I missed it for so long. |
|
We dismantled or diffy swerve after drop but I asked a local team who built one if I can borrow it ill send a video when I pick it up (it is only one module idk if thats fine) |
|
Or we can also have @Astr0clad who is more familiar with Diffy take a more thorough look at it. |
|
At first glance, the kinematics seem more in line with a two-motor coaxial setup. I will take a second look tonight to verify this though. |
|
@Astr0clad any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamps DifferentialSwerveModuleBase.java