refactor: autoconfig -> cloth-config #258
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin drafting a cloth-config screen to replace the autoconfig one. Show the draft screen when `shift` is held while opening the config screen.
Used to implement the "reset" button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from AutoConfig to the less abstracted cloth-config2.
Strictly speaking, AutoConfig is part of the cloth-config project, so we aren't dropping any dependencies yet. But we are taking ownership of how our config is persisted.
The current JSON persistence implementation simply matches what AutoConfig does; the point of this PR is not to change any functionality, but simply to shift responsibility.
I've marked the PR a draft for now until it can be further tested and polished, but it should be ready for testing and review.
We ought to be cautious here, we don't want to end up breaking user configs just for an internal refactor!