Update to 1.21.3 #252
Update to 1.21.3 #252
Conversation
| ClientInput input = new ClientInput(); | ||
| Input keyPresses = mc.player.input.keyPresses; | ||
| input.keyPresses = new Input( | ||
| false, | ||
| false, | ||
| false, | ||
| false, | ||
| false, | ||
| keyPresses.shift(), | ||
| false | ||
| ); |
There was a problem hiding this comment.
This will be simplified by #253, but this is fine and shouldn't be blocked by that PR.
| @@ -26,25 +26,25 @@ release_type=release | |||
| # https://maven.parchmentmc.org/org/parchmentmc/data | |||
| # Forge dependencies use maven's version range spec: | |||
| # https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html | |||
| minecraft_version=1.21 | |||
| minecraft_version=1.21.3 | |||
| parchment_version=1.21-2024.07.07 | |||
There was a problem hiding this comment.
We can bump parchment to 2024.07.28, although it's unrelated to porting so maybe in a separate commit or separate PR?
gradle.properties
Outdated
| @@ -26,25 +26,25 @@ release_type=release | |||
| # https://maven.parchmentmc.org/org/parchmentmc/data | |||
| # Forge dependencies use maven's version range spec: | |||
| # https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html | |||
| minecraft_version=1.21 | |||
| minecraft_version=1.21.3 | |||
| parchment_version=1.21-2024.07.07 | |||
| supported_mc_versions= | |||
|
|
|||
| fabric_loader_version=0.15.11 | |||
There was a problem hiding this comment.
I believe we should bump our loader dep to 0.16.7
There was a problem hiding this comment.
Looks like you've bumped fabric_loader_req by mistake instead of fabric_loader_version.
One relates to the "minimum requirement" that ends up in our mod metadata, while the other is the version we download to build against.
There was a problem hiding this comment.
Yeah, sorry I misunderstood what you meant. It's fixed now
There was a problem hiding this comment.
TBH I don't know what the minimum req loader to run fabric 1.21.2+ would be, but if we're unsure it's better to ere on the side of caution and not bump it...
If you know roughly what it should be, I'm happy for it to also be bumped as appropriate 😁
common/src/main/java/net/xolt/freecam/mixins/EntityRendererMixin.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Everything looks good. Testing locally I haven't found any issues yet.
Anyone wanting to test this before it gets released can use the CI build artifacts.
|
Thanks again for dealing with this! 🚀 |
|
Thanks for the quick review ^^ |
No description provided.