CI fixes #217
Merged
CI fixes #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
commented
Jun 3, 2024
Someone seems to have found a fix for this here: |
This is to bypass branch-protection rules on `main`.
Use actor's username for the commit author, but use the bot email since we don't have access to user's display names or emails.
MattSturgeon
force-pushed
the
ci/build-prs
branch
from
ef619c5 to
bbacda5
Compare
|
Thanks for the feedback. This is ready for another review 😄 |
hashalite
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
buildCI on PRsThis should make the build workflow run on PRs too, as originally intended.
It may end up running twice when pushing to PRs on non-fork branches though...
Use owner's PAT in bump-version CI
To bypass branch protection, we can use a Personal Access Token generated on @hashalite's account. Should be added to the repo secrets as "
HASHALITE_PAT".Ensure bump-version commits as a bot
This is the default anyway for the committer, but for author stefanzweifel/git-auto-commit-action uses the last commit's author, which may or may not be the same as the CI's triggerer (
github.actor).