Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "build" CI workflow #194

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add a "build" CI workflow #194

merged 1 commit into from
Apr 19, 2024

Conversation

MattSturgeon
Copy link
Member

@MattSturgeon MattSturgeon commented Apr 2, 2024

This PR adds a CI workflow that builds every commit pushed (including to PRs) and uploads the jars as artifacts.

No reason to wait for #153 to get some basics like this 😃

This PR's own CI job successfully ran here.

Runs `./gradlew build` and uploads the artifacts.
@MattSturgeon
Copy link
Member Author

MattSturgeon commented Apr 2, 2024

Not sure if it's a good thing that an yet-unmerged workflow was able to run? Just thinking about security implications...

EDIT:

I believe this relates to this in Settings -> Actions -> General:

Fork pull request workflows from outside collaborators

Choose which subset of outside collaborators will require approval to run workflows on their pull requests. Learn more about approving workflow runs from public forks.

Might be an idea to read that article and check your setting.

@MattSturgeon
Copy link
Member Author

It might make sense to do this as a build matrix:

  • matrix can be computed from enabled_platforms in gradle.properties
  • building one platform at a time would make build failures easier to diagnose
  • uploading artifacts would be much simpler
  • the build would probably be slightly slower
  • idk if it makes more sense to run the matrix in parallel (speed) or sequentially (better caching)

@MattSturgeon MattSturgeon merged commit 7725342 into main Apr 19, 2024
1 check passed
@MattSturgeon MattSturgeon deleted the ci/build branch April 19, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants