[1.16.5] Backport of DisplayTest feature #9809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrRapero720
changed the title
|
i am not sure why but TC always takes checks from main branch, wich means old branches check was broken. specially below 1.18.2. building pass but other no implemented check fails by that, so nothing that i can fix on my side. |
SrRapero720
force-pushed
the
backports/16.5-District
branch
2 times, most recently
from
73b887c to
fc4449c
Compare
|
rebased and fixed. |
SrRapero720
force-pushed
the
backports/16.5-District
branch
from
fc4449c to
dd2b959
Compare
|
rebased again |
|
For anyone who want want to know If anyone knows how to fix the damn 1.17.1 please summon me to add the patch quicky |
PaintNinja
added
the
Queued
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remade the PR, having gradle fix with feature addition
Backport of the DisplayTest feature added in #8656. Of course code was adapted to work on Java 8 and Pair system used on 1.16.5
Already tested and works fine
I modified AppleSkin mods.toml to use "MATCH_VERSION" and "IGNORE_SERVER_VERSION" and this is how it looks (ordered)
