Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] ControlNet unit preset management #1974

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

huchenlei
Copy link
Collaborator

@huchenlei huchenlei commented Aug 24, 2023

Users have requested to be able to save easily save and load controlnet unit presets in #1854.

This PR implements a preset manager UI that allows users to save/load ControlNet unit presets. Presets are persisted locally as text file under presets/.

Screen Capture 025 - Stable Diffusion - 127 0 0 1

Known issues:

@huchenlei huchenlei added the enhancement New feature or request label Aug 24, 2023
@lllyasviel
Copy link
Collaborator

will you maintain this?

@huchenlei
Copy link
Collaborator Author

Hint fixed.

Sure I will be maintaining this part. It is not complex.

@huchenlei huchenlei merged commit 6dc7b4f into Mikubill:main Aug 25, 2023
1 check passed
@lllyasviel
Copy link
Collaborator

control type is not stored, make it feel a a bit unpleasant.
Also it should restore blank when controlnet_ui_group.py detects changes. if you get time you may take a look at line 843-872 in controlnet_ui_group.py to see how to implement this

@huchenlei
Copy link
Collaborator Author

The design here is that if user make changes with a preset selected, pressing save button will overwrite that preset. To save as a new preset, user need to select new preset and click save.

Going to implement storage of control type later.

@lllyasviel
Copy link
Collaborator

lllyasviel commented Aug 25, 2023

but if I selected preset A and made some changes, how can I go back to A using the preset A?
This should be the major use case of preset

@huchenlei
Copy link
Collaborator Author

Yea, it can be awkward to select new preset and then select preset A to clear modifications made.

However, I believe there need to be a way to to edit the preset. Do you think it would be better if we make an edit button and let user edit the raw infostring in a popup box?

@lllyasviel
Copy link
Collaborator

you may want to design it a bit - and if you think the current form is not mature enough this can be temporarily reverted.
but it is ok if just put here and update it if you move fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants