Updated packaging approach for reducing the number of github requests #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is needed only for huge updates like year switch in header files. Currently per 1 Asset Upload-Delete request function call we use 4-20 github requests. With 450 assets (at the moment when this PR was created) we exceed 5000 request limit if we need to reupload all of them (we always have chack indexes script running in the background twice in an hour and 1 scheduled workflow at the moment takes 900 requests) So with this update packaging script will take ~10 requests in the beginning to take all uploaded assets and then just 2 requests for Asset Delete-Upload function call.
IvanRuzavin
changed the title
StrahinjaJacimovic
requested changes
Jan 13, 2025
StrahinjaJacimovic
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed only for huge updates like year switch in header files.
Currently per 1 Asset Upload-Delete request function call we use 4-20 github requests.
With 450 assets (at the moment when this PR was created) we exceed 5000 request limit if we need to reupload all of them (we always have chack indexes script running in the background twice in an hour and 1 scheduled workflow at the moment takes 900 requests)
So with this update packaging script will take ~10 requests in the beginning to take all uploaded assets and then just 2 requests for Asset Delete-Upload function call.