Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a case of false type equivalency #1175

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

povik
Copy link
Contributor

@povik povik commented Nov 14, 2024

Please see the included test to understand the issue. For both types ->getParentScope() is null, maybe there's a deeper issue which causes the missing scope, but I have been able to resolve some AST inconsistencies with this fix.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (1ac3d34) to head (b317c0c).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files         195      195           
  Lines       50207    50207           
=======================================
  Hits        47512    47512           
  Misses       2695     2695           
Files with missing lines Coverage Δ
source/ast/types/Type.cpp 95.46% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac3d34...b317c0c. Read the comment docs.

@MikePopoloski MikePopoloski merged commit 981c28e into MikePopoloski:master Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants