slang-reflect: Add support to reflect Unions #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 94.77% 94.62% -0.15%
==========================================
Files 191 195 +4
Lines 47802 50181 +2379
==========================================
+ Hits 45304 47486 +2182
- Misses 2498 2695 +197
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This commit adds support to slang-reflect to support unions. As SystemVerilog structs are not 1:1 translatable to C++, because, for example, a C++ struct might not be stored as an array of bits as it is done in SystemVerilog. The SystemVerilog union is reflected as a struct with a single member with the data of the union. Helper functions are generated to retrieve the different members of the union with the corresponding type.
* Make use of std::views:keys * Fix typo in a comment
Sustrak
force-pushed
the
feature/slang-reflect-unions
branch
from
eab24e7
to
c613d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.