hermetic builds #1160
Merged
hermetic builds #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds explicit arguments to the generator scripts to point to the input such that they can be used in a hermetic build where the scripts do not run from the source directory. Remaining inputs are assume to be in the same directory. Additional style changes include: - checking the path for opening files rather than relying on exceptions. - explicity define the type for and check for assignments to curropts array to enable static type checking of the code. - adding missing includes in generated code.
Hermetic builds look for all necessary includes for the features used in the header files. This commit adds the missing includes.
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
==========================================
- Coverage 94.84% 94.76% -0.09%
==========================================
Files 191 193 +2
Lines 47944 50002 +2058
==========================================
+ Hits 45472 47383 +1911
- Misses 2472 2619 +147
... and 149 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Python bindings required updating the arguments to the syntax_gen script. Prints the OSError message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit arguments to the generator scripts to point to the input
such that they can be used in a hermetic build where the scripts do
not run from the source directory. Remaining inputs are assume to be
in the same directory.
Adds missing includes.
Fixes #1155