Don't require an extra bit for the sign for signed vector literals wi…

…th a binary, octal, or hex base
MikePopoloski · Oct 18, 2024 · 2e6c82b · 2e6c82b
1 parent 8b2a9b7
commit 2e6c82b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/source/parsing/NumberParser.cpp b/source/parsing/NumberParser.cpp
@@ -258,10 +258,6 @@ Token NumberParser::finishValue(Token firstToken, bool singleToken, bool isNegat
         if (!digits[0].isUnknown())
             bits += (bitwidth_t)std::bit_width(digits[0].value);
 
-        // Signed numbers need an extra bit for the sign.
-        if (signFlag)
-            bits++;
-
         if (bits > sizeBits) {
             if (sizeBits == 0) {
                 if (bits > SVInt::MAX_BITS) {

diff --git a/tests/unittests/parsing/ExpressionParsingTests.cpp b/tests/unittests/parsing/ExpressionParsingTests.cpp
@@ -917,15 +917,17 @@ TEST_CASE("Vector literal overflow parsing") {
 shortint a = -16'sd32769;
 int b = -32'sd2147483649;
 int c = 32'd4294967297;
+
+// No warnings for these
 int d = 9'so777;
+int e = 4'sb1000;
 )";
     parseCompilationUnit(text);
 
-    REQUIRE(diagnostics.size() == 4);
+    REQUIRE(diagnostics.size() == 3);
     CHECK(diagnostics[0].code == diag::VectorLiteralOverflow);
     CHECK(diagnostics[1].code == diag::VectorLiteralOverflow);
     CHECK(diagnostics[2].code == diag::VectorLiteralOverflow);
-    CHECK(diagnostics[3].code == diag::VectorLiteralOverflow);
 }
 
 TEST_CASE("Diagnosing missing base after signed specifier parsing") {