test(deps): update github action upload-artifact to v4 (cypress-io#1098)

* test(deps): update github action upload-artifact to v4

* docs: update readme for upload-artifact@v4 usage

.github/workflows/example-chrome.yml

@@ -32,7 +32,7 @@ jobs:
           # As of Cypress v8.0 the `cypress run` command
           # executes tests in `headless` mode by default
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: screenshots-headless-chrome
           path: examples/browser/cypress/screenshots
@@ -50,7 +50,7 @@ jobs:
           headed: true
           summary-title: 'Chrome headed'
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: screenshots-headed-chrome
           path: examples/browser/cypress/screenshots

.github/workflows/example-firefox.yml

@@ -24,7 +24,7 @@ jobs:
           browser: firefox
 
       # report screenshot size and store the screenshots as test artifacts
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: screenshots-in-firefox
           path: examples/browser/cypress/screenshots

README.md

@@ -372,7 +372,7 @@ jobs:
 
 ### Project ID and Record Key
 
-To record the project needs `projectId` and `recordKey`. 
+To record the project needs `projectId` and `recordKey`.
 
 Typically, the `projectId` is stored in the [Cypress Configuration File](https://docs.cypress.io/guides/references/configuration#Configuration-File), while the `recordKey` is set as a [CLI parameter](https://docs.cypress.io/guides/guides/command-line#cypress-run-record-key-lt-record-key-gt). If you want to avoid this, both the `projectId` and `recordKey` can be provided as environment variables using [GitHub secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions).
 
@@ -424,7 +424,7 @@ jobs:
 
 Please refer to the [Cypress Cloud Git information environment variables](https://on.cypress.io/guides/continuous-integration/introduction#Git-information) section in our documentation for more examples.
 
-Please refer to the [default GitHub environment variables](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) for additional GitHub examples. 
+Please refer to the [default GitHub environment variables](https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables) for additional GitHub examples.
 
 ### Automatic PR number and URL detection
 
@@ -582,14 +582,14 @@ jobs:
       - uses: actions/checkout@v4
       - uses: cypress-io/github-action@v6
       # after the test run completes store videos and any screenshots
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         # add the line below to store screenshots only on failures
         # if: failure()
         with:
           name: cypress-screenshots
           path: cypress/screenshots
           if-no-files-found: ignore # 'warn' or 'error' are also available, defaults to `warn`
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: cypress-videos
           path: cypress/videos