included venv activation for python scripts

[AlvinSchiller]

New PR for the venv activation problem adressed in #2144
This implements the ideas from #2144 (comment)

• have "proxy" shell scripts that handle the venv activation and setup the needed working dir, to be run from any relativ path.
• better accessability of the scripts for the user, e.g. group with alike scripts like installation or tools
• run_*.py scripts can't be moved right now, as the module imports are not accessable from sub dirs, so they have to stay in the root folder. This could be a future addition (possible solution https://stackoverflow.com/a/50194143)

[coveralls]

Pull Request Test Coverage Report for Build 7769607281

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 38.384%

---

Totals
Change from base Build 7748821301:	0.0%
Covered Lines:	418
Relevant Lines:	1089

---

💛 - Coveralls

[s-martin]

Would it be a problem, if a user manually activates a venv and then runs a sh script, which also activates the venv?

[AlvinSchiller]

Would it be a problem, if a user manually activates a venv and then runs a sh script, which also activates the venv?

Nope, tested multiple activations and couldn't see a sideeffect. The installations process does the same with the RFID Reader setup script.

[pabera]

Looks good. In another iteration, a way to abstract the repetition of the individual bash files could be to build a single installer script with an argument.

$ run.sh rpc_tool
$ run.sh publicity_sniffer
$ run.sh register_rfid_reader

This could then prepare again for Whiptail 🙃

[AlvinSchiller]

Looks good. In another iteration, a way to abstract the repetition of the individual bash files could be to build a single installer script with an argument.

$ run.sh rpc_tool
$ run.sh publicity_sniffer
$ run.sh register_rfid_reader

This could then prepare again for Whiptail 🙃

Thought about that too 😁👍

[AlvinSchiller]

I will run some final test over this, otherwise ready to merge.

Edit: Do we then need the motd message at all (#2225)?

[pabera]

Edit: Do we then need the motd message at all (#2225)?

Not for the reason of informing about the venv, but I truly believe we should keep this! 🚀

##################################################
   ___  __ ______  _  __________ ____   __  _  _
  / _ \/ // / __ \/ |/ /  _/ __/(  _ \ /  \( \/ )
 / ___/ _  / /_/ /    // // _/   ) _ ((  O ))  (
/_/  /_//_/\____/_/|_/___/____/ (____/ \__/(_/\_)

            Welcome to your Phoniebox
##################################################

[AlvinSchiller]

👍 i will update the Message to only have the banner :)

[AlvinSchiller]

With this condition that updates are broken and a fresh installation is needed, should we add this already to v3.5.0?

[pabera]

... should we add this already to v3.5.0?

Aligned!

[AlvinSchiller]

Last fix included. Good to go, if nothing left.

[pabera]

Merge it!